remove unneeeded allocation in computeBoundingBox #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance by reducing GC for Insert and Delete intensive workloads. As seen in the pprof graph to be attached in the pull request, before this change time was spent on: computeBoundingBox 16.26% runtime.systemstack 20.06% which adds up to almost 40%. After this change, computeBoundingBox spends only 2%, and all traces of GC are gone.
dhconnelly
approved these changes
Aug 17, 2022
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance by reducing GC for Insert and Delete intensive
workloads.
As seen in the pprof graph to be attached in the pull request,
before this change time was spent on:
computeBoundingBox 16.26%
runtime.systemstack 20.06%
which adds up to almost 40%.
After this change, computeBoundingBox spends only 2%, and all traces of
GC are gone.